Review Request 121333: Fix lockscreen theme fallback

[Kai Uwe Broulik]

> On Dez. 3, 2014, 12:46 vorm., Aleix Pol Gonzalez wrote:
> > Looks good to me, when I did the port it used to work, I'm unsure where we went wrong. Maybe it would be possible to get a unit test?

In 8a5aaf59a922c493acb2d063c84e91aa0c2f17eb you removed the main.qml of the org.kde.passworddialog which makes the package invalid, without in 5a118aa9f4dabf35695e31a8e188b4c814df01b8 accounting for that you are just using a hardcoded source now :)

Given it is completely unused now, should I remove the entire themes folder in the greeter, which just has a folder with a desktop file in it?


- Kai Uwe


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121333/#review71278
-----------------------------------------------------------


On Dez. 2, 2014, 10:10 nachm., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121333/
> -----------------------------------------------------------
> 
> (Updated Dez. 2, 2014, 10:10 nachm.)
> 
> 
> Review request for Plasma and Martin Gräßlin.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> When the look and feel lockscreen theme failed to load for whatever reason, it is supposed to fall back to a built-in theme to not lock the user out of the system.
> 
> The fallbak did not work and crashed with an invalid package access, trapping you in an endless kscreenlocker_greet reboot loop. This is most likely a porting oversight since the default lockscreen theme, as indicated by the constant, is no longer present or used.
> 
> 
> Diffs
> -----
> 
>   ksmserver/screenlocker/greeter/greeterapp.cpp d3f9f28 
> 
> Diff: https://git.reviewboard.kde.org/r/121333/diff/
> 
> 
> Testing
> -------
> 
> Messed around in the look and feel qml file, got fallback.
> 
> The fallback theme is quite broken, though, with the switch user button not working, the dialog background missing as well as the wallpaper but at leas it now works again.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141203/0fb1bf9f/attachment-0001.html>