Review Request 121333: Fix lockscreen theme fallback

[Martin Gräßlin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121333/#review71280
-----------------------------------------------------------

Ship it!


Maybe we also need a way to indicate that the greeter is broken and that kscreenlocker should unlock the screen. At that state it would be possible as the lock is not fully established yet (keyboard/mouse is grabbed, but not yet blanked).

- Martin Gräßlin


On Dec. 2, 2014, 11:10 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121333/
> -----------------------------------------------------------
> 
> (Updated Dec. 2, 2014, 11:10 p.m.)
> 
> 
> Review request for Plasma and Martin Gräßlin.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> When the look and feel lockscreen theme failed to load for whatever reason, it is supposed to fall back to a built-in theme to not lock the user out of the system.
> 
> The fallbak did not work and crashed with an invalid package access, trapping you in an endless kscreenlocker_greet reboot loop. This is most likely a porting oversight since the default lockscreen theme, as indicated by the constant, is no longer present or used.
> 
> 
> Diffs
> -----
> 
>   ksmserver/screenlocker/greeter/greeterapp.cpp d3f9f28 
> 
> Diff: https://git.reviewboard.kde.org/r/121333/diff/
> 
> 
> Testing
> -------
> 
> Messed around in the look and feel qml file, got fallback.
> 
> The fallback theme is quite broken, though, with the switch user button not working, the dialog background missing as well as the wallpaper but at leas it now works again.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141203/12b9d597/attachment.html>