Review Request 119974: port Slider to QtControls

[Marco Martin]

> On Aug. 28, 2014, 1:31 p.m., Kai Uwe Broulik wrote:
> > src/declarativeimports/plasmacomponents/qml/Slider.qml, lines 125-126
> > <https://git.reviewboard.kde.org/r/119974/diff/1/?file=307981#file307981line125>
> >
> >     Is that still needed?
> 
> Marco Martin wrote:
>     I don't know, but the base component doesn't have it.
>     Maybe Frederik knows?

ok, so it's still needed because upstream is in 5.4 but not 5.3


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119974/#review65430
-----------------------------------------------------------


On Aug. 28, 2014, 12:30 p.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119974/
> -----------------------------------------------------------
> 
> (Updated Aug. 28, 2014, 12:30 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> this ports slider to qtcontrols and adds a style as well.
> unfortunately the inverted property is not accessible anymore so becomes deprecated and noop
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/plasmacomponents/qml/Slider.qml c532590 
>   src/declarativeimports/plasmacomponents/qml/styles/SliderStyle.qml PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/119974/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140828/78a1fd88/attachment.html>