Review Request 119974: port Slider to QtControls

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119974/#review65431
-----------------------------------------------------------



src/declarativeimports/plasmacomponents/qml/Slider.qml
<https://git.reviewboard.kde.org/r/119974/#comment45716>

    QtQuick.Controls.Button



src/declarativeimports/plasmacomponents/qml/styles/SliderStyle.qml
<https://git.reviewboard.kde.org/r/119974/#comment45719>

    in the last review we explicilty set panel to Item {}
    
    if it's needed there, it's needed here.



src/declarativeimports/plasmacomponents/qml/styles/SliderStyle.qml
<https://git.reviewboard.kde.org/r/119974/#comment45717>

    Have you tried in vertical mode.
    We don't seem to handling orientation anywhere?
    
    (maybe it's done for us, I haven't looked)



src/declarativeimports/plasmacomponents/qml/styles/SliderStyle.qml
<https://git.reviewboard.kde.org/r/119974/#comment45720>

    where is styleData defined?
    Seems we're accidentally relying on private API.



src/declarativeimports/plasmacomponents/qml/styles/SliderStyle.qml
<https://git.reviewboard.kde.org/r/119974/#comment45712>

    redundant



src/declarativeimports/plasmacomponents/qml/styles/SliderStyle.qml
<https://git.reviewboard.kde.org/r/119974/#comment45721>

    Won't this position them outside the repeater?



src/declarativeimports/plasmacomponents/qml/styles/SliderStyle.qml
<https://git.reviewboard.kde.org/r/119974/#comment45722>

    can you describe this in a comment (I'm a bit lost)
    
    There's a potential divide by 0 is the model size is 1.


- David Edmundson


On Aug. 28, 2014, 12:30 p.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119974/
> -----------------------------------------------------------
> 
> (Updated Aug. 28, 2014, 12:30 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> this ports slider to qtcontrols and adds a style as well.
> unfortunately the inverted property is not accessible anymore so becomes deprecated and noop
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/plasmacomponents/qml/Slider.qml c532590 
>   src/declarativeimports/plasmacomponents/qml/styles/SliderStyle.qml PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/119974/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140828/bdf274bd/attachment-0001.html>