Review Request 119882: Use standard way of setting version numbers in Plasma

[David Edmundson]

> On Aug. 21, 2014, 10:43 a.m., David Edmundson wrote:
> > kcms/kfontinst/lib/CMakeLists.txt, line 15
> > <https://git.reviewboard.kde.org/r/119882/diff/1/?file=306812#file306812line15>
> >
> >     not sure this is true.
> >     
> >     it's a private library ABI can change at any point, if that happens should the .so number change too?
> 
> Jonathan Riddell wrote:
>     Yes if that should happen it should be changed.  But while it doesn't happen it's fine to use the project version

But we could call it SO_VERSION in the root cmake instead of PROJECT_MAJOR, and then there's no future problem


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119882/#review64972
-----------------------------------------------------------


On Aug. 21, 2014, 10:39 a.m., Jonathan Riddell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119882/
> -----------------------------------------------------------
> 
> (Updated Aug. 21, 2014, 10:39 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> Use standard way of setting version numbers in Plasma
> Also set plasma-desktop to depend on KF5 5.1
> This requires plasma-framework with PlasmaQuick version file https://git.reviewboard.kde.org/r/119881/
> 
> 
> Diffs
> -----
> 
>   config-workspace.h.cmake f2b315ff603d485b93552edb1e4f1c78e2183284 
>   kcms/kfontinst/lib/CMakeLists.txt 799707d240204c01e7aab0dc2581f4a3e83d6c00 
>   CMakeLists.txt d3655bcf4a23644617f54dd955ba1a1632684083 
> 
> Diff: https://git.reviewboard.kde.org/r/119882/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jonathan Riddell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140821/3a8d1a4a/attachment-0001.html>