<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119882/">https://git.reviewboard.kde.org/r/119882/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 21st, 2014, 10:43 a.m. UTC, <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/119882/diff/1/?file=306812#file306812line15" style="color: black; font-weight: bold; text-decoration: underline;">kcms/kfontinst/lib/CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">15</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb">set_target_properties</span><span class="p">(</span><span class="s">kfontinst</span> <span class="s">PROPERTIES</span> <span class="s">VERSION</span> <span class="o">${</span><span class="nv"><span class="hl">GENERIC_LIB</span>_VERSION</span><span class="o">}</span> <span class="s">SOVERSION</span> <span class="s"><span class="hl">5</span></span> <span class="p">)</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">15</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb">set_target_properties</span><span class="p">(</span><span class="s">kfontinst</span> <span class="s">PROPERTIES</span> <span class="s">VERSION</span> <span class="o">${</span><span class="nv"><span class="hl">PROJECT</span>_VERSION</span><span class="o">}</span> <span class="s">SOVERSION</span> <span class="o"><span class="hl">${</span></span><span class="nv"><span class="hl">PROJECT_VERSION_MAJOR</span></span><span class="o"><span class="hl">}</span></span> <span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">not sure this is true.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">it's a private library ABI can change at any point, if that happens should the .so number change too?</p></pre>
</blockquote>
<p>On August 21st, 2014, 10:52 a.m. UTC, <b>Jonathan Riddell</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Yes if that should happen it should be changed. But while it doesn't happen it's fine to use the project version</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">But we could call it SO_VERSION in the root cmake instead of PROJECT_MAJOR, and then there's no future problem</p></pre>
<br />
<p>- David</p>
<br />
<p>On August 21st, 2014, 10:39 a.m. UTC, Jonathan Riddell wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Jonathan Riddell.</div>
<p style="color: grey;"><i>Updated Aug. 21, 2014, 10:39 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Use standard way of setting version numbers in Plasma
Also set plasma-desktop to depend on KF5 5.1
This requires plasma-framework with PlasmaQuick version file https://git.reviewboard.kde.org/r/119881/</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>config-workspace.h.cmake <span style="color: grey">(f2b315ff603d485b93552edb1e4f1c78e2183284)</span></li>
<li>kcms/kfontinst/lib/CMakeLists.txt <span style="color: grey">(799707d240204c01e7aab0dc2581f4a3e83d6c00)</span></li>
<li>CMakeLists.txt <span style="color: grey">(d3655bcf4a23644617f54dd955ba1a1632684083)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119882/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>