Review Request 119758: Add option to DigitalClock applet to show date

[Marco Martin]

> On Aug. 13, 2014, 11 a.m., David Edmundson wrote:
> > applets/digital-clock/package/contents/ui/DigitalClock.qml, line 70
> > <https://git.reviewboard.kde.org/r/119758/diff/1/?file=305016#file305016line70>
> >
> >     Do we really want the same text label with the same font?
> >     
> >     I'd like some screenshots.
> 
> Dan Vrátil wrote:
>     Why not?
>     
>     I played with having two labels, but it was a huge mess and I wasn't able to make it work properly.

again, Screenshots! but just looking at the code, it will be something very wide on horizontal panels:
i would see it better as the date being a label vertically stacked with the time, in smallestreadablefont size


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119758/#review64446
-----------------------------------------------------------


On Aug. 13, 2014, 10:51 a.m., Dan Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119758/
> -----------------------------------------------------------
> 
> (Updated Aug. 13, 2014, 10:51 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 335006
>     https://bugs.kde.org/show_bug.cgi?id=335006
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> This patch adds option to show date in the DigitalClock applet, something I was very much missing after switching to Plasma 5 :-)
> 
> Similary to the KDE 4 applet, users can choose from long, short and narrow date formats.
> 
> 
> Diffs
> -----
> 
>   applets/digital-clock/package/contents/config/main.xml 74ac640 
>   applets/digital-clock/package/contents/ui/DigitalClock.qml 20babc3 
>   applets/digital-clock/package/contents/ui/configAppearance.qml ab67e14 
> 
> Diff: https://git.reviewboard.kde.org/r/119758/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dan Vrátil
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140813/bfa044ac/attachment.html>