Review Request 119758: Add option to DigitalClock applet to show date

[Dan Vrátil]

> On Aug. 13, 2014, 1 p.m., David Edmundson wrote:
> > applets/digital-clock/package/contents/ui/DigitalClock.qml, line 70
> > <https://git.reviewboard.kde.org/r/119758/diff/1/?file=305016#file305016line70>
> >
> >     Do we really want the same text label with the same font?
> >     
> >     I'd like some screenshots.

Why not?

I played with having two labels, but it was a huge mess and I wasn't able to make it work properly.


> On Aug. 13, 2014, 1 p.m., David Edmundson wrote:
> > applets/digital-clock/package/contents/ui/configAppearance.qml, line 39
> > <https://git.reviewboard.kde.org/r/119758/diff/1/?file=305017#file305017line39>
> >
> >     can be just:
> >     
> >     property string cfg_dateFormat: model[currentIndex]["name"]
> >     
> >     and remove the onCurrentIndexChanged

That does not work, the property is not updated when I select another item in the combobox.


> On Aug. 13, 2014, 1 p.m., David Edmundson wrote:
> > applets/digital-clock/package/contents/ui/DigitalClock.qml, line 148
> > <https://git.reviewboard.kde.org/r/119758/diff/1/?file=305016#file305016line148>
> >
> >     In the size helper we calculate the size of 
> >     00:00:00 which is the widest string so that text doesn't jump about.
> >     
> >     Here you're working out the size of the current day. Which is going to be dynamic. Given this is only calculated once on startup, if you start it in May you'll get it broken if Plasma keeps running till September when the text will no longer fit.

Hmm, that's true - it might even break just when a day changes.


- Dan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119758/#review64446
-----------------------------------------------------------


On Aug. 13, 2014, 12:51 p.m., Dan Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119758/
> -----------------------------------------------------------
> 
> (Updated Aug. 13, 2014, 12:51 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 335006
>     https://bugs.kde.org/show_bug.cgi?id=335006
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> This patch adds option to show date in the DigitalClock applet, something I was very much missing after switching to Plasma 5 :-)
> 
> Similary to the KDE 4 applet, users can choose from long, short and narrow date formats.
> 
> 
> Diffs
> -----
> 
>   applets/digital-clock/package/contents/config/main.xml 74ac640 
>   applets/digital-clock/package/contents/ui/DigitalClock.qml 20babc3 
>   applets/digital-clock/package/contents/ui/configAppearance.qml ab67e14 
> 
> Diff: https://git.reviewboard.kde.org/r/119758/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dan Vrátil
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140813/8db97ccd/attachment-0001.html>