Review Request 119756: Plasma Active: Initial port of the active filebrowser

[Marco Martin]

> On Aug. 13, 2014, 10:37 a.m., Antonis Tsiapaliokas wrote:
> > applications/filebrowser/package/contents/ui/CategorySidebar.qml, line 59
> > <https://git.reviewboard.kde.org/r/119756/diff/1/?file=305001#file305001line59>
> >
> >     I guess that this one has to go,
> >     since the activities doesn't support ratings anymore. right?

yes


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119756/#review64441
-----------------------------------------------------------


On Aug. 13, 2014, 10:23 a.m., Antonis Tsiapaliokas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119756/
> -----------------------------------------------------------
> 
> (Updated Aug. 13, 2014, 10:23 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-mobile
> 
> 
> Description
> -------
> 
> This patch restores some of the basic functionality back to the filebrowser.
> 
> 
> Diffs
> -----
> 
>   applications/filebrowser/package/contents/ui/CategorySidebar.qml 91a84b0 
>   applications/filebrowser/package/contents/ui/TagsBar.qml 3140674 
>   CMakeLists.txt e90cec6 
>   applications/CMakeLists.txt eb1591f 
>   applications/filebrowser/CMakeLists.txt 3db78ab 
>   applications/filebrowser/package/contents/ui/Browser.qml c8aa15d 
>   applications/filebrowser/package/contents/ui/BrowserFrame.qml e585fdd 
>   applications/filebrowser/package/contents/ui/TimelineSidebar.qml a67f8af 
>   applications/filebrowser/package/contents/ui/ToolBar.qml 3511504 
>   applications/filebrowser/package/contents/ui/TypeFilter.qml 03d397f 
>   applications/filebrowser/package/contents/ui/background-logo.png 338182a 
>   applications/filebrowser/package/contents/ui/background-logo.svgz 634602b 
>   applications/filebrowser/package/contents/ui/main.qml ecb1cd7 
>   applications/filebrowser/src/CMakeLists.txt 2550fbe 
>   applications/filebrowser/src/filebrowser.h 0825a30 
>   applications/filebrowser/src/filebrowser.cpp 6e170aa 
>   applications/filebrowser/src/main.cpp 0129641 
> 
> Diff: https://git.reviewboard.kde.org/r/119756/diff/
> 
> 
> Testing
> -------
> 
> What has been ported so far:
> 
> * Removable devices works
> * Navigation inside the removable device
> * Baloo resources like Documents, Images etc
> * Activity resources
>  
> What is missing:
> 
> * Tags support (it requires some patches into the Baloo Component)
> * Timeline support (it requires some patches into the Baloo Component)
> * Imageviewer
> * Audio previewer
> 
> Bugs
> 
> * FolderModel doesn't return the correct icon for the folders. It should return "inode/directory" but it returns "application/octet-stream"
> * The code requires some more clean up, but it would be better to sort this out after the ImageViewer and the Audio Previewer port.
> 
> 
> File Attachments
> ----------------
> 
> filebrowser.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/08/13/a18d5a4d-7625-4ccb-9b02-e50a9d4f0224__filebrowser.png
> 
> 
> Thanks,
> 
> Antonis Tsiapaliokas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140813/703a5b63/attachment.html>