<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119756/">https://git.reviewboard.kde.org/r/119756/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 13th, 2014, 10:37 a.m. UTC, <b>Antonis Tsiapaliokas</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/119756/diff/1/?file=305001#file305001line59" style="color: black; font-weight: bold; text-decoration: underline;">applications/filebrowser/package/contents/ui/CategorySidebar.qml</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">46</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="kd">id: ratingLabel</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I guess that this one has to go,<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
since the activities doesn't support ratings anymore. right?</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">yes</p></pre>
<br />
<p>- Marco</p>
<br />
<p>On August 13th, 2014, 10:23 a.m. UTC, Antonis Tsiapaliokas wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Antonis Tsiapaliokas.</div>
<p style="color: grey;"><i>Updated Aug. 13, 2014, 10:23 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-mobile
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This patch restores some of the basic functionality back to the filebrowser.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">What has been ported so far:</p>
<ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 1em;line-height: inherit;white-space: normal;">
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Removable devices works</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Navigation inside the removable device</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Baloo resources like Documents, Images etc</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Activity resources</li>
</ul>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">What is missing:</p>
<ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 1em;line-height: inherit;white-space: normal;">
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Tags support (it requires some patches into the Baloo Component)</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Timeline support (it requires some patches into the Baloo Component)</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Imageviewer</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Audio previewer</li>
</ul>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Bugs</p>
<ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 1em;line-height: inherit;white-space: normal;">
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">FolderModel doesn't return the correct icon for the folders. It should return "inode/directory" but it returns "application/octet-stream"</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">The code requires some more clean up, but it would be better to sort this out after the ImageViewer and the Audio Previewer port.</li>
</ul></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applications/filebrowser/package/contents/ui/CategorySidebar.qml <span style="color: grey">(91a84b0)</span></li>
<li>applications/filebrowser/package/contents/ui/TagsBar.qml <span style="color: grey">(3140674)</span></li>
<li>CMakeLists.txt <span style="color: grey">(e90cec6)</span></li>
<li>applications/CMakeLists.txt <span style="color: grey">(eb1591f)</span></li>
<li>applications/filebrowser/CMakeLists.txt <span style="color: grey">(3db78ab)</span></li>
<li>applications/filebrowser/package/contents/ui/Browser.qml <span style="color: grey">(c8aa15d)</span></li>
<li>applications/filebrowser/package/contents/ui/BrowserFrame.qml <span style="color: grey">(e585fdd)</span></li>
<li>applications/filebrowser/package/contents/ui/TimelineSidebar.qml <span style="color: grey">(a67f8af)</span></li>
<li>applications/filebrowser/package/contents/ui/ToolBar.qml <span style="color: grey">(3511504)</span></li>
<li>applications/filebrowser/package/contents/ui/TypeFilter.qml <span style="color: grey">(03d397f)</span></li>
<li>applications/filebrowser/package/contents/ui/background-logo.png <span style="color: grey">(338182a)</span></li>
<li>applications/filebrowser/package/contents/ui/background-logo.svgz <span style="color: grey">(634602b)</span></li>
<li>applications/filebrowser/package/contents/ui/main.qml <span style="color: grey">(ecb1cd7)</span></li>
<li>applications/filebrowser/src/CMakeLists.txt <span style="color: grey">(2550fbe)</span></li>
<li>applications/filebrowser/src/filebrowser.h <span style="color: grey">(0825a30)</span></li>
<li>applications/filebrowser/src/filebrowser.cpp <span style="color: grey">(6e170aa)</span></li>
<li>applications/filebrowser/src/main.cpp <span style="color: grey">(0129641)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119756/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/08/13/a18d5a4d-7625-4ccb-9b02-e50a9d4f0224__filebrowser.png">filebrowser.png</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>