Review Request 119719: Streamline notifications plasmoid

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119719/
-----------------------------------------------------------

(Updated Aug. 11, 2014, 7:18 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma.


Repository: plasma-workspace


Description
-------

This streamlines the notification plasmoid a bit.

- Get rid of hardcoded sizes (was quite cramped here)

- Get rid of huge "Transfers" heading. It was the same size as the systray title and added little value

I have no idea what's wrong with the action button.


Diffs
-----

  applets/notifications/package/contents/ui/Jobs.qml 2f5a88e 
  applets/notifications/package/contents/ui/NotificationDelegate.qml 0b97d77 

Diff: https://git.reviewboard.kde.org/r/119719/diff/


Testing
-------

Yup.


File Attachments
----------------

Notifications (before)
  https://git.reviewboard.kde.org/media/uploaded/files/2014/08/11/da7f1f4e-df8f-4eda-aca8-1c4fcc6fdeda__notifyold.png
Notifications (after)
  https://git.reviewboard.kde.org/media/uploaded/files/2014/08/11/1064cc3d-8ae0-4267-ae6e-1643f8a0a23a__notifynew.png


Thanks,

Kai Uwe Broulik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140811/9a2e2e96/attachment.html>