Review Request 119683: [Idea] Rotate popup arrow animated instead of changing element
Martin Klapetek
martin.klapetek at gmail.com
Mon Aug 11 09:50:13 UTC 2014
> On Aug. 9, 2014, 9:06 p.m., David Edmundson wrote:
> > >It only uses arrow-top so might give issues with themes that have different arrow looks(?)
> >
> > Yeah, that's quite a concern. One possible solution is to only rotate if there is only a up arrow element. That might mean updating a lot more code though.
How about rotating and fading to the other arrow at the same time? Might be quite resources consuming tho
- Martin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119683/#review64123
-----------------------------------------------------------
On Aug. 9, 2014, 9 p.m., Kai Uwe Broulik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119683/
> -----------------------------------------------------------
>
> (Updated Aug. 9, 2014, 9 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> This is a simple patch which makes the popup arrow rotate in an animated way when opening/closing the popup instead of switching elements.
>
>
> Diffs
> -----
>
> applets/systemtray/package/contents/ui/CompactRepresentation.qml 579dde6
>
> Diff: https://git.reviewboard.kde.org/r/119683/diff/
>
>
> Testing
> -------
>
> Works, the arrow always rotates facing the system tray icons, ie. clockwise in a top panel and counter-clockwise in a bottom panel.
>
> It only uses arrow-top so might give issues with themes that have different arrow looks(?)
>
>
> Thanks,
>
> Kai Uwe Broulik
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140811/450da03b/attachment.html>
More information about the Plasma-devel
mailing list