Review Request 119683: [Idea] Rotate popup arrow animated instead of changing element

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119683/#review64123
-----------------------------------------------------------


>It only uses arrow-top so might give issues with themes that have different arrow looks(?)

Yeah, that's quite a concern. One possible solution is to only rotate if there is only a up arrow element. That might mean updating a lot more code though.

- David Edmundson


On Aug. 9, 2014, 7 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119683/
> -----------------------------------------------------------
> 
> (Updated Aug. 9, 2014, 7 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> This is a simple patch which makes the popup arrow rotate in an animated way when opening/closing the popup instead of switching elements.
> 
> 
> Diffs
> -----
> 
>   applets/systemtray/package/contents/ui/CompactRepresentation.qml 579dde6 
> 
> Diff: https://git.reviewboard.kde.org/r/119683/diff/
> 
> 
> Testing
> -------
> 
> Works, the arrow always rotates facing the system tray icons, ie. clockwise in a top panel and counter-clockwise in a bottom panel.
> 
> It only uses arrow-top so might give issues with themes that have different arrow looks(?)
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140809/75f3366b/attachment.html>