Review Request 119515: Support per-activity favourites for Kickoff

[Ivan Čukić]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119515/
-----------------------------------------------------------

(Updated Aug. 9, 2014, 8:48 a.m.)


Review request for Plasma, Eike Hein, Marco Martin, and Sebastian Kügler.


Summary (updated)
-----------------

Support per-activity favourites for Kickoff


Repository: plasma-desktop


Description
-------

This patch adds the support to have favourites linked to activities.

It uses org.kde.activities.ResourceModel to show favorites.

It supports:
 - adding a favourite to all activities (the previous behaviour)
 - adding a favourite to the current activity
 - moving a favourite between 'all activities' and 'current activity' modes (it does not affect non-current activities)
 - drag-and-drop reordering of items (like the previous one)
 - sorting A-Z, Z-A (like the previous one)
 - transitions previously defined favourites to the new system*

Context menu item captions could maybe use some improvement.

Screenshot available at: http://ivan.fomentgroup.org/blog/2014/07/27/per-activity-favourites-in-kickoff/#/comments

* this can also be used for defining the default favourites in a global kickoffrc file - instead of them being hard-coded like they currently are.


Diffs
-----

  applets/kickoff/CMakeLists.txt 28e7029 
  applets/kickoff/core/favoritesmodel.h 27a0626 
  applets/kickoff/core/favoritesmodel.cpp f05588b 
  applets/kickoff/core/kickoffplugin.cpp f549981 
  applets/kickoff/core/krunnermodel.h 3916829 
  applets/kickoff/core/krunnermodel.cpp db2adab 
  applets/kickoff/package/contents/ui/ContextMenu.qml 6a67874 
  applets/kickoff/package/contents/ui/FavoritesView.qml 6c2d5d4 
  applets/kickoff/package/contents/ui/FullRepresentation.qml 6291b7c 

Diff: https://git.reviewboard.kde.org/r/119515/diff/


Testing
-------

Yes


Thanks,

Ivan Čukić

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140809/b0682a73/attachment.html>