Review Request 119603: Use Qt API for figuring out the dialog screen
David Edmundson
david at davidedmundson.co.uk
Tue Aug 5 16:07:15 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119603/#review63873
-----------------------------------------------------------
Ship it!
Been running it all day, including some monitor hotplugging and moving some things.
- David Edmundson
On Aug. 4, 2014, 3:38 p.m., Aleix Pol Gonzalez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119603/
> -----------------------------------------------------------
>
> (Updated Aug. 4, 2014, 3:38 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-framework
>
>
> Description
> -------
>
> At the moment it's trying to translate the item position and iterating through all screens, but we can get the screen through the item's window.
>
>
> Diffs
> -----
>
> src/plasmaquick/dialog.cpp fb33ffa
>
> Diff: https://git.reviewboard.kde.org/r/119603/diff/
>
>
> Testing
> -------
>
> Tests pass, everything works without glitches (I used to have some, depending on the screen configuration).
>
>
> Thanks,
>
> Aleix Pol Gonzalez
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140805/ebed76a2/attachment.html>
More information about the Plasma-devel
mailing list