Review Request 119603: Use Qt API for figuring out the dialog screen

[Marco Martin]

> On Aug. 4, 2014, 3:44 p.m., Marco Martin wrote:
> > wasn't screenforitem introduced because window()->screen() then won't notice if the qwindow changes screen?
> > did you test by dragging a dialog between screens if all still works correctly?
> 
> Aleix Pol Gonzalez wrote:
>     Works here, but then I'm on Qt 5.4. I'll poke David to test it.
> 
> David Edmundson wrote:
>     When that code was introduced we didn't update the screen on panel and desktop windows; that was changed at some point.
>     I'll run with this patch for a few days and report back.

ok.
If it works correctly on 5.3 changing screens, is fine for me.


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119603/#review63795
-----------------------------------------------------------


On Aug. 4, 2014, 3:38 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119603/
> -----------------------------------------------------------
> 
> (Updated Aug. 4, 2014, 3:38 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> At the moment it's trying to translate the item position and iterating through all screens, but we can get the screen through the item's window.
> 
> 
> Diffs
> -----
> 
>   src/plasmaquick/dialog.cpp fb33ffa 
> 
> Diff: https://git.reviewboard.kde.org/r/119603/diff/
> 
> 
> Testing
> -------
> 
> Tests pass, everything works without glitches (I used to have some, depending on the screen configuration).
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140804/717fc510/attachment.html>