Review Request 119602: support config dialog with current krunner config dialog

Marco Martin notmart at gmail.com
Tue Aug 5 10:50:07 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119602/
-----------------------------------------------------------

(Updated Aug. 5, 2014, 10:50 a.m.)


Review request for Plasma.


Repository: plasma-desktop


Description
-------

unlike the previous one, this still uses category based config.
tough, if in a category there are runners with a config dialog, enable a config button in the item.
If there would be more runners with config in one category, it would put all the config dialogs in a tabbar.
The code for showing the config dialog comes from KPluginLoader


Diffs (updated)
-----

  kcms/runners/CMakeLists.txt 257baef 
  kcms/runners/kcm.h 0458430 
  kcms/runners/kcm.cpp 0de07fb 

Diff: https://git.reviewboard.kde.org/r/119602/diff/


Testing
-------


File Attachments
----------------

krunner.png
  https://git.reviewboard.kde.org/media/uploaded/files/2014/08/04/447dbfb8-e813-4cb9-aabb-a2b9f8d324a0__krunner.png


Thanks,

Marco Martin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140805/6035960a/attachment.html>


More information about the Plasma-devel mailing list