Review Request 119602: support config dialog with current krunner config dialog

[Marco Martin]

> On Aug. 5, 2014, 9:44 a.m., Vishesh Handa wrote:
> > kcms/runners/kcm.cpp, line 88
> > <https://git.reviewboard.kde.org/r/119602/diff/3/?file=295947#file295947line88>
> >
> >     The manager does not seem to be deleted. Is this correct?

added a parent, it should live for the kcm lifetime but has to be leleted with it


> On Aug. 5, 2014, 9:44 a.m., Vishesh Handa wrote:
> > kcms/runners/kcm.cpp, line 179
> > <https://git.reviewboard.kde.org/r/119602/diff/3/?file=295947#file295947line179>
> >
> >     Are you sure this doesn't result in a crash?
> >     
> >     Either way, it's redundant.

didn't crash, but yeah, completely forgotten leftover :)


> On Aug. 5, 2014, 9:44 a.m., Vishesh Handa wrote:
> > kcms/runners/kcm.cpp, line 224
> > <https://git.reviewboard.kde.org/r/119602/diff/3/?file=295947#file295947line224>
> >
> >     Why the 1.2?

just to add a bit of padding, icons look quite crushed together otherwise


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119602/#review63839
-----------------------------------------------------------


On Aug. 5, 2014, 9:24 a.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119602/
> -----------------------------------------------------------
> 
> (Updated Aug. 5, 2014, 9:24 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> unlike the previous one, this still uses category based config.
> tough, if in a category there are runners with a config dialog, enable a config button in the item.
> If there would be more runners with config in one category, it would put all the config dialogs in a tabbar.
> The code for showing the config dialog comes from KPluginLoader
> 
> 
> Diffs
> -----
> 
>   kcms/runners/CMakeLists.txt 257baef 
>   kcms/runners/kcm.h 0458430 
>   kcms/runners/kcm.cpp 0de07fb 
> 
> Diff: https://git.reviewboard.kde.org/r/119602/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> krunner.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/08/04/447dbfb8-e813-4cb9-aabb-a2b9f8d324a0__krunner.png
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140805/89bf282f/attachment-0001.html>