Review Request 119596: Fix the upstart version check if the version is not a valid float
Philip Muskovac
yofel at gmx.net
Sun Aug 3 21:28:12 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119596/
-----------------------------------------------------------
Review request for Plasma.
Repository: powerdevil
Description
-------
Recently upstart started using X.Y.Z versioning which breaks the version check as e.g. 1.13.1 is not a valid float anymore and gets translated to 0 by toFloat()
Now the check only keeps the X.Y part of the version before the conversion.
This needs to be applied in powerdevil and kde-workspace KDE/4.11.
Diffs
-----
daemon/backends/upower/powerdevilupowerbackend.cpp ea1741f
Diff: https://git.reviewboard.kde.org/r/119596/diff/
Testing
-------
Tested on kubuntu utopic(dev) with powerdevil 5.0.0, kde-workspace 4.11.10 and upstart 1.13.1
Thanks,
Philip Muskovac
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140803/e1240b23/attachment.html>
More information about the Plasma-devel
mailing list