Review Request 111770: Implemented search feature in Local Browsing.

[Akshay Ratan]

> On Sept. 11, 2013, 7:31 a.m., Sinny Kumari wrote:
> > One issue
> > Suppose I searched for videos folder in search bar. Now, with search filter i can see videos folder in mediabrowser. Later when I click on video folder to broswe inside then it shows me blank. This is happening becasue still it is trying to search with name video. This should not happen, search should be called only for current browsing page where user typed it
> 
> Sinny Kumari wrote:
>     Snapshots:
>     http://wstaw.org/m/2013/09/11/snapshot1.png (when searched for videos)
>     http://wstaw.org/m/2013/09/11/snapshot2.png (when clicked on filterd search i.e on videos)
>
> 
> Sinny Kumari wrote:
>     Status?

I think Harshit worked on it a few months back. I l check with him once too.

I would suggest not discarding this request as a very small step is needed to remove the bug and implement the feature correctly.


- Akshay


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/111770/#review39798
-----------------------------------------------------------


On Sept. 10, 2013, 7:31 p.m., Akshay Ratan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/111770/
> -----------------------------------------------------------
> 
> (Updated Sept. 10, 2013, 7:31 p.m.)
> 
> 
> Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan.
> 
> 
> Repository: plasma-mediacenter
> 
> 
> Description
> -------
> 
> Plasma Media Center now supports searching in local files and media. Used Regular expression to match the name.
> 
> Request to merge the branch akshay_localSearch to master of PMC.
> 
> 
> Diffs
> -----
> 
>   browsingbackends/localfiles/localfilesabstractbackend.h 84758e4 
>   browsingbackends/localfiles/localfilesabstractbackend.cpp 1144e49 
>   browsingbackends/localfiles/localfilesabstractmodel.h 43f50b7 
>   browsingbackends/localfiles/localfilesabstractmodel.cpp ebfc602 
>   mediaelements/mediabrowser/MediaBrowser.qml 6ae777f 
> 
> Diff: https://git.reviewboard.kde.org/r/111770/diff/
> 
> 
> Testing
> -------
> 
> Works as intended.
> 
> 
> Thanks,
> 
> Akshay Ratan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140803/ee0c64ba/attachment-0001.html>