Review Request 117824: Discard window thumbnail pixmap after texture got destroyed by SceneGraph

Martin Gräßlin mgraesslin at kde.org
Wed Apr 30 05:44:14 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117824/
-----------------------------------------------------------

(Updated April 30, 2014, 7:44 a.m.)


Review request for Plasma and Alexander Richardson.


Changes
-------

Added QQuickWindow::TextureOwnsGLTexture


Bugs: 333482
    http://bugs.kde.org/show_bug.cgi?id=333482


Repository: plasma-framework


Description
-------

Discard window thumbnail pixmap after texture got destroyed by SceneGraph

If the window holding the WindowThumbnail item goes away the texture hold
by the node is destroyed but our bound window pixmap is not yet freed.
This results in incorrect state the next time the WindowThumbnail is
shown.

To get back into a clean state discardPixmap() is called if there is no
texture but a bound low level pixmap.

BUG: 333482


Diffs (updated)
-----

  src/declarativeimports/core/windowthumbnail.cpp d1a7fef1fc5fd119592710d80274d2abe0c8b3b1 

Diff: https://git.reviewboard.kde.org/r/117824/diff/


Testing
-------


Thanks,

Martin Gräßlin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140430/1e8e57c0/attachment-0001.html>


More information about the Plasma-devel mailing list