Review Request 117802: Merge ShowDesktop and ShowDashboard plasma applets into one
Gregor Mi
codeminister at publicstatic.de
Wed Apr 30 01:26:48 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117802/
-----------------------------------------------------------
(Updated April 30, 2014, 1:26 a.m.)
Review request for Plasma, Aleix Pol Gonzalez and Dominik Haumann.
Changes
-------
rebased on frameworks branch (to serve as a base for porting to QML later)
Repository: kdeplasma-addons
Description
-------
This is a proposition to merge the plasma applets ShowDashboard and ShowDesktop into one since both share the same basic logic. As a bonus users with large panels have to option to have both functions stacked vertically so save space on an horizontal panel.
Detailed description see here: http://codestruct.jimdo.com/struct/showdeskboard/
- shows a small screencast how it looks like when the container panel is resized
- shows a table with screenshots that shows how different settings in the configuration dialog look like on small and large panels.
(This review request is based on https://git.reviewboard.kde.org/r/117681/)
Diffs (updated)
-----
applets/showdesktop/CMakeLists.txt eb532075cbe8ff734bebdfc8d35af7e9e9f5c32d
applets/showdesktop/showdesktop.h 5aeb8481df824f6ea9d7969cf544876f5fb3473c
applets/showdesktop/showdesktop.cpp d712519918fcf2efe4dbbb5337a29316d53e759a
applets/showdesktop/showdesktopConfig.ui PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/117802/diff/
Testing
-------
Thanks,
Gregor Mi
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140430/cdb1a42f/attachment.html>
More information about the Plasma-devel
mailing list