Review Request 117802: Merge ShowDesktop and ShowDashboard plasma applets into one

[Gregor Mi]

> On April 27, 2014, 8:10 p.m., Aleix Pol Gonzalez wrote:
> > .gitignore, line 1
> > <https://git.reviewboard.kde.org/r/117802/diff/1/?file=268624#file268624line1>
> >
> >     You probably don't want to submit this file, you can have gitignore set system-wide, if you want.

You are right. Thanks for the hint.


On April 27, 2014, 8:10 p.m., Gregor Mi wrote:
> > Regarding the actual patch, I don't know if kdeplasma-addons master is frozen, but I think so. If so, maybe you want to look this up for the frameworks branch?

I'll rebase it for frameworks branch.


- Gregor


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117802/#review56691
-----------------------------------------------------------


On April 27, 2014, 5:55 p.m., Gregor Mi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117802/
> -----------------------------------------------------------
> 
> (Updated April 27, 2014, 5:55 p.m.)
> 
> 
> Review request for Plasma, Aleix Pol Gonzalez and Dominik Haumann.
> 
> 
> Repository: kdeplasma-addons
> 
> 
> Description
> -------
> 
> This is a proposition to merge the plasma applets ShowDashboard and ShowDesktop into one since both share the same basic logic. As a bonus users with large panels have to option to have both functions stacked vertically so save space on an horizontal panel.
> 
> Detailed description see here: http://codestruct.jimdo.com/struct/showdeskboard/
> - shows a small screencast how it looks like when the container panel is resized
> - shows a table with screenshots that shows how different settings in the configuration dialog look like on small and large panels.
> 
> (This review request is based on https://git.reviewboard.kde.org/r/117681/)
> 
> 
> Diffs
> -----
> 
>   .gitignore PRE-CREATION 
>   .reviewboardrc PRE-CREATION 
>   applets/showdesktop/CMakeLists.txt eb532075cbe8ff734bebdfc8d35af7e9e9f5c32d 
>   applets/showdesktop/showdesktop.h 5aeb8481df824f6ea9d7969cf544876f5fb3473c 
>   applets/showdesktop/showdesktop.cpp d712519918fcf2efe4dbbb5337a29316d53e759a 
>   applets/showdesktop/showdesktopConfig.ui PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/117802/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gregor Mi
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140430/4be272d2/attachment.html>