Review Request 117800: Move tests inside libs/mediacenter and make them compile with the library sources instead of linking to libplasmamediacenter

[Bhushan Shah]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117800/#review56671
-----------------------------------------------------------



libs/mediacenter/CMakeLists.txt
<https://git.reviewboard.kde.org/r/117800/#comment39516>

    Addeed Twice?



libs/mediacenter/test/CMakeLists.txt
<https://git.reviewboard.kde.org/r/117800/#comment39517>

    Duplicate?


- Bhushan Shah


On April 27, 2014, 6:32 p.m., Shantanu Tushar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117800/
> -----------------------------------------------------------
> 
> (Updated April 27, 2014, 6:32 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-mediacenter
> 
> 
> Description
> -------
> 
> Doing so gives us two benefits-
> 1. We no longer have to export classes just to test them
> 2. We can use ORM mapped classes such as Artist, Album without extra magic for tests
> 
> (the diff shows deleted/new files because of the move, reviewing CMakeLists.txt changes should be sufficient)
> 
> 
> Diffs
> -----
> 
>   libs/CMakeLists.txt 59334e9 
>   libs/mediacenter/CMakeLists.txt 37769f6 
>   libs/mediacenter/test/CMakeLists.txt PRE-CREATION 
>   libs/mediacenter/test/fakemediavalidator.h PRE-CREATION 
>   libs/mediacenter/test/fakemediavalidator.cpp PRE-CREATION 
>   libs/mediacenter/test/lastfmimagefetchertest.h PRE-CREATION 
>   libs/mediacenter/test/lastfmimagefetchertest.cpp PRE-CREATION 
>   libs/mediacenter/test/mediacentertest.h PRE-CREATION 
>   libs/mediacenter/test/mediacentertest.cpp PRE-CREATION 
>   libs/mediacenter/test/medialibrarytest.h PRE-CREATION 
>   libs/mediacenter/test/medialibrarytest.cpp PRE-CREATION 
>   libs/mediacenter/test/mediatest.h PRE-CREATION 
>   libs/mediacenter/test/mediatest.cpp PRE-CREATION 
>   libs/mediacenter/test/pmcmediatest.h PRE-CREATION 
>   libs/mediacenter/test/pmcmediatest.cpp PRE-CREATION 
>   libs/mediacenter/test/singletonfactorytest.h PRE-CREATION 
>   libs/mediacenter/test/singletonfactorytest.cpp PRE-CREATION 
>   libs/mediacenter/test/testhelpers.h PRE-CREATION 
>   libs/test/CMakeLists.txt 52ec617 
>   libs/test/fakemediavalidator.h 201973c 
>   libs/test/fakemediavalidator.cpp c2fdc17 
>   libs/test/lastfmimagefetchertest.h 6422824 
>   libs/test/lastfmimagefetchertest.cpp 9d06079 
>   libs/test/mediacentertest.h 6997ae9 
>   libs/test/mediacentertest.cpp bb4c4d1 
>   libs/test/medialibrarytest.h 2f8b476 
>   libs/test/medialibrarytest.cpp 746d5b2 
>   libs/test/mediatest.h 965bc7e 
>   libs/test/mediatest.cpp 86ec0d0 
>   libs/test/pmcmediatest.h 2322176 
>   libs/test/pmcmediatest.cpp 4bdcae6 
>   libs/test/singletonfactorytest.h 79e4197 
>   libs/test/singletonfactorytest.cpp b9fc987 
>   libs/test/testhelpers.h 9825e85 
> 
> Diff: https://git.reviewboard.kde.org/r/117800/diff/
> 
> 
> Testing
> -------
> 
> compiles, all unit tests pass
> 
> 
> Thanks,
> 
> Shantanu Tushar
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140427/02ea5166/attachment-0001.html>