<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117800/">https://git.reviewboard.kde.org/r/117800/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/117800/diff/1/?file=268549#file268549line115" style="color: black; font-weight: bold; text-decoration: underline;">libs/mediacenter/CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">115</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb">function</span><span class="p">(</span><span class="s">pmc_test</span> <span class="s">TESTNAME</span><span class="p">)</span></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">116</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="err">kde4_add_executable(${TESTNAME}</span> <span class="err">${plasmamediacenter_SRCS}</span> <span class="err">test/${TESTNAME}.cpp</span> <span class="err">test/fakemediavalidator.cpp)</span></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">117</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="nb">add_test</span><span class="p">(</span><span class="s">pmc-libs-</span><span class="o">${</span><span class="nv">TESTNAME</span><span class="o">}</span> <span class="o">${</span><span class="nv">TESTNAME</span><span class="o">}</span><span class="p">)</span></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">118</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="nb">target_link_libraries</span><span class="p">(</span><span class="o">${</span><span class="nv">TESTNAME</span><span class="o">}</span></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">119</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="o">${</span><span class="nv">KDE4_KDECORE_LIBRARY</span><span class="o">}</span> <span class="o">${</span><span class="nv">KDE4_KIO_LIBS</span><span class="o">}</span></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">120</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="o">${</span><span class="nv">QT_QTSQL_LIBRARIES</span><span class="o">}</span> <span class="o">${</span><span class="nv">QT_QTTEST_LIBRARIES</span><span class="o">}</span> <span class="o">${</span><span class="nv">QT_QTGUI_LIBRARIES</span><span class="o">}</span> <span class="o">${</span><span class="nv">QT_QTNETWORK_LIBRARIES</span><span class="o">}</span> <span class="o">${</span><span class="nv">QT_QTXML_LIBRARIES</span><span class="o">}</span> <span class="o">${</span><span class="nv">QT_QTDECLARATIVE_LIBRARIES</span><span class="o">}</span></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">121</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="o">${</span><span class="nv">Boost_LIBRARIES</span><span class="o">}</span> <span class="o">${</span><span class="nv">QxOrm_LIBRARIES</span><span class="o">}</span> <span class="o">${</span><span class="nv">TAGLIB_LIBRARIES</span><span class="o">}</span></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">122</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Addeed Twice?</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/117800/diff/1/?file=268550#file268550line11" style="color: black; font-weight: bold; text-decoration: underline;">libs/mediacenter/test/CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">11</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb">add_definitions</span><span class="p">(</span><span class="s">-D_QX_SERIALIZE_BINARY_ENABLED</span> <span class="s">-D_QX_SERIALIZE_XML_ENABLED</span> <span class="s">-D_BUILDING_PMC</span><span class="p">)</span></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">12</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">13</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb">SET</span><span class="p">(</span><span class="s">QT_USE_QTMAIN</span> <span class="s">TRUE</span><span class="p">)</span></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">14</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb">SET</span><span class="p">(</span><span class="s">QT_USE_QTTEST</span> <span class="s">TRUE</span><span class="p">)</span></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">15</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">16</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb">function</span><span class="p">(</span><span class="s">pmc_test</span> <span class="s">TESTNAME</span><span class="p">)</span></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">17</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="err">qt4_automoc(${TESTNAME}.cpp</span> <span class="err">fakemediavalidator.cpp)</span></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">18</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="nb">add_executable</span><span class="p">(</span><span class="o">${</span><span class="nv">TESTNAME</span><span class="o">}</span> <span class="o">${</span><span class="nv">TESTNAME</span><span class="o">}</span><span class="s">.cpp</span> <span class="s">fakemediavalidator.cpp</span><span class="p">)</span></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">19</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="nb">add_test</span><span class="p">(</span><span class="s">pmc-libs-</span><span class="o">${</span><span class="nv">TESTNAME</span><span class="o">}</span> <span class="o">${</span><span class="nv">TESTNAME</span><span class="o">}</span><span class="p">)</span></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">20</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="nb">target_link_libraries</span><span class="p">(</span><span class="o">${</span><span class="nv">TESTNAME</span><span class="o">}</span> <span class="s">plasmamediacenter</span> <span class="o">${</span><span class="nv">KDE4_KDECORE_LIBRARY</span><span class="o">}</span> <span class="o">${</span><span class="nv">QT_QTSQL_LIBRARIES</span><span class="o">}</span> <span class="o">${</span><span class="nv">QT_QTTEST_LIBRARIES</span><span class="o">}</span> <span class="o">${</span><span class="nv">QT_QTGUI_LIBRARIES</span><span class="o">}</span> <span class="o">${</span><span class="nv">Boost_LIBRARIES</span><span class="o">}</span> <span class="o">${</span><span class="nv">QxOrm_LIBRARIES</span><span class="o">}</span><span class="p">)</span></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">21</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb">endfunction</span><span class="p">(</span><span class="s">pmc_test</span><span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Duplicate?</pre>
</div>
<br />
<p>- Bhushan Shah</p>
<br />
<p>On April 27th, 2014, 6:32 p.m. IST, Shantanu Tushar wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Shantanu Tushar.</div>
<p style="color: grey;"><i>Updated April 27, 2014, 6:32 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-mediacenter
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Doing so gives us two benefits-
1. We no longer have to export classes just to test them
2. We can use ORM mapped classes such as Artist, Album without extra magic for tests
(the diff shows deleted/new files because of the move, reviewing CMakeLists.txt changes should be sufficient)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">compiles, all unit tests pass</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/CMakeLists.txt <span style="color: grey">(59334e9)</span></li>
<li>libs/mediacenter/CMakeLists.txt <span style="color: grey">(37769f6)</span></li>
<li>libs/mediacenter/test/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/mediacenter/test/fakemediavalidator.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/mediacenter/test/fakemediavalidator.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/mediacenter/test/lastfmimagefetchertest.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/mediacenter/test/lastfmimagefetchertest.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/mediacenter/test/mediacentertest.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/mediacenter/test/mediacentertest.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/mediacenter/test/medialibrarytest.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/mediacenter/test/medialibrarytest.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/mediacenter/test/mediatest.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/mediacenter/test/mediatest.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/mediacenter/test/pmcmediatest.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/mediacenter/test/pmcmediatest.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/mediacenter/test/singletonfactorytest.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/mediacenter/test/singletonfactorytest.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/mediacenter/test/testhelpers.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/test/CMakeLists.txt <span style="color: grey">(52ec617)</span></li>
<li>libs/test/fakemediavalidator.h <span style="color: grey">(201973c)</span></li>
<li>libs/test/fakemediavalidator.cpp <span style="color: grey">(c2fdc17)</span></li>
<li>libs/test/lastfmimagefetchertest.h <span style="color: grey">(6422824)</span></li>
<li>libs/test/lastfmimagefetchertest.cpp <span style="color: grey">(9d06079)</span></li>
<li>libs/test/mediacentertest.h <span style="color: grey">(6997ae9)</span></li>
<li>libs/test/mediacentertest.cpp <span style="color: grey">(bb4c4d1)</span></li>
<li>libs/test/medialibrarytest.h <span style="color: grey">(2f8b476)</span></li>
<li>libs/test/medialibrarytest.cpp <span style="color: grey">(746d5b2)</span></li>
<li>libs/test/mediatest.h <span style="color: grey">(965bc7e)</span></li>
<li>libs/test/mediatest.cpp <span style="color: grey">(86ec0d0)</span></li>
<li>libs/test/pmcmediatest.h <span style="color: grey">(2322176)</span></li>
<li>libs/test/pmcmediatest.cpp <span style="color: grey">(4bdcae6)</span></li>
<li>libs/test/singletonfactorytest.h <span style="color: grey">(79e4197)</span></li>
<li>libs/test/singletonfactorytest.cpp <span style="color: grey">(b9fc987)</span></li>
<li>libs/test/testhelpers.h <span style="color: grey">(9825e85)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117800/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>