Review Request 117770: rename liboxygen libraries

Jonathan Riddell jr at jriddell.org
Fri Apr 25 16:39:53 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117770/
-----------------------------------------------------------

(Updated April 25, 2014, 4:39 p.m.)


Review request for Plasma and Martin Gräßlin.


Changes
-------

Rename library where it is used elsewhere, this fixes the compile


Repository: oxygen


Description
-------

liboxygen libraries used for the oxygen widget style should be renamed as they are runtime items which need to coinstall with equivalents from kdelibs4 land.

However this does not compile, I'm confused by the target_include_directories() line for oxygenstyle, this change stops it including KMessageBox


Diffs (updated)
-----

  kstyle/config/CMakeLists.txt 560c409 
  kwin-decoration/CMakeLists.txt ff99b25 
  kstyle/CMakeLists.txt 8c76de3 
  kwin-decoration/config/CMakeLists.txt c7e6d49 
  kwin-decoration/demo/CMakeLists.txt 60c3018 
  liboxygen/CMakeLists.txt 4419809 

Diff: https://git.reviewboard.kde.org/r/117770/diff/


Testing
-------


Thanks,

Jonathan Riddell

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140425/62a7c34e/attachment.html>


More information about the Plasma-devel mailing list