<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117770/">https://git.reviewboard.kde.org/r/117770/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma and Martin Gräßlin.</div>
<div>By Jonathan Riddell.</div>
<p style="color: grey;"><i>Updated April 25, 2014, 4:39 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Rename library where it is used elsewhere, this fixes the compile</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
oxygen
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">liboxygen libraries used for the oxygen widget style should be renamed as they are runtime items which need to coinstall with equivalents from kdelibs4 land.
However this does not compile, I'm confused by the target_include_directories() line for oxygenstyle, this change stops it including KMessageBox</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kstyle/config/CMakeLists.txt <span style="color: grey">(560c409)</span></li>
<li>kwin-decoration/CMakeLists.txt <span style="color: grey">(ff99b25)</span></li>
<li>kstyle/CMakeLists.txt <span style="color: grey">(8c76de3)</span></li>
<li>kwin-decoration/config/CMakeLists.txt <span style="color: grey">(c7e6d49)</span></li>
<li>kwin-decoration/demo/CMakeLists.txt <span style="color: grey">(60c3018)</span></li>
<li>liboxygen/CMakeLists.txt <span style="color: grey">(4419809)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117770/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>