Review Request 117746: Don't make blocking dbus calls from KDED for appmenu.

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117746/
-----------------------------------------------------------

Review request for Plasma and Cedric Bellegarde.


Repository: kde-workspace


Description
-------

    Avoid call to blocking QDBusInterface
    
    QDBusInterface is an evil command with a secret blocking call inside
    to introspect the interface.
    
    Apps can get in a blocked state where they query the kded
    for information (such as testing if we have a network, or loading the
    timezone) and the kded is blocked waiting for the application trying
    to load the menus.
    
    This results in apps and kded being frozen.


Diffs
-----

  appmenu/menuimporter.cpp b55b7d3 

Diff: https://git.reviewboard.kde.org/r/117746/diff/


Testing
-------

I have *NOT* tested this and am unable to.

I would appreciate it if someone else could check everything still works.


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140424/d1823304/attachment.html>