Review Request 116800: introduce the command line argument --appletPath in plasmoidviewer
Giorgos Tsiapaliokas
giorgos.tsiapaliokas at kde.org
Thu Apr 24 13:38:28 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116800/
-----------------------------------------------------------
(Updated April 24, 2014, 4:38 p.m.)
Review request for Plasma.
Changes
-------
I have updated the diff into the latest frameworks branch and I have fixed the issues.
Repository: plasmate
Description
-------
The appletPath contains the path of the applet, if the user
doesn't give a path then the refresh button of the plasmoidviewer will
be hidden because we need the plasmoid path in order to execute
`plasmapkg2 -u $myapplet`. Also this patch installs the plasmoid automatically
so the user can refresh the plasmoid without having to install the plasmoid manually.
Diffs (updated)
-----
plasmoidviewer/main.cpp 009acbb
plasmoidviewer/qmlpackages/shell/contents/views/SdkButtons.qml 8a125ea
plasmoidviewer/view.h d997f15
plasmoidviewer/view.cpp aa89145
Diff: https://git.reviewboard.kde.org/r/116800/diff/
Testing
-------
1. paths like ~/kf5/foo/plasmoid work
2. the plasmoid is being loaded even without the --appletPath
Thanks,
Giorgos Tsiapaliokas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140424/1e3bab5e/attachment-0001.html>
More information about the Plasma-devel
mailing list