Review Request 117732: Move settings class to lib from shell
Shantanu Tushar
shantanu at kde.org
Thu Apr 24 10:18:33 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117732/#review56364
-----------------------------------------------------------
Ship it!
Ship It!
- Shantanu Tushar
On April 24, 2014, 6:10 a.m., Bhushan Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117732/
> -----------------------------------------------------------
>
> (Updated April 24, 2014, 6:10 a.m.)
>
>
> Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan.
>
>
> Repository: plasma-mediacenter
>
>
> Description
> -------
>
> As discussed on IRC.
>
>
> Diffs
> -----
>
> libs/mediacenter/CMakeLists.txt f5aa827
> libs/mediacenter/settings.h PRE-CREATION
> libs/mediacenter/settings.cpp PRE-CREATION
> shells/newshell/CMakeLists.txt 9d9ea29
> shells/newshell/mainwindow.cpp 9735a0a
> shells/newshell/settings.h 1fdcb8d
> shells/newshell/settings.cpp ea7ea7d
>
> Diff: https://git.reviewboard.kde.org/r/117732/diff/
>
>
> Testing
> -------
>
> Compiles
> Links
> Test passes
> Works
>
>
> Thanks,
>
> Bhushan Shah
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140424/9dc7747a/attachment.html>
More information about the Plasma-devel
mailing list