Review Request 117732: Move settings class to lib from shell

Bhushan Shah bhush94 at gmail.com
Thu Apr 24 06:10:01 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117732/
-----------------------------------------------------------

(Updated April 24, 2014, 11:40 a.m.)


Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan.


Changes
-------

add more reviewers


Repository: plasma-mediacenter


Description
-------

As discussed on IRC.


Diffs
-----

  libs/mediacenter/CMakeLists.txt f5aa827 
  libs/mediacenter/settings.h PRE-CREATION 
  libs/mediacenter/settings.cpp PRE-CREATION 
  shells/newshell/CMakeLists.txt 9d9ea29 
  shells/newshell/mainwindow.cpp 9735a0a 
  shells/newshell/settings.h 1fdcb8d 
  shells/newshell/settings.cpp ea7ea7d 

Diff: https://git.reviewboard.kde.org/r/117732/diff/


Testing
-------

Compiles
Links
Test passes
Works


Thanks,

Bhushan Shah

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140424/943406fc/attachment.html>


More information about the Plasma-devel mailing list