Review Request 117563: React to containment status changes

Aleix Pol Gonzalez aleixpol at kde.org
Tue Apr 15 12:16:09 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117563/
-----------------------------------------------------------

(Updated April 15, 2014, 12:16 p.m.)


Review request for Plasma.


Changes
-------

Apparently, I never understood what unhide was doing.

This patch makes it possible to control when to show the panel when we're in auto-hide mode and uses it to react to the Containment::status changes, as well as the Plasma::Applet::activated signals.

Now everything seems to be working correctly here.


Repository: plasma-workspace


Description
-------

At the moment the Panel didn't have any code to react status changes from the containment (and therefore its applets).

This patch aims to add this, only problem being that it doesn't work. The "unhide requested" and "unhiding" messages are being displayed though.

I've been looking for the code that does the actual display of the auto-hiding panels and I wasn't able to find it, help is welcome.


Diffs (updated)
-----

  shell/panelview.h 056a1e4 
  shell/panelview.cpp 53d690a 

Diff: https://git.reviewboard.kde.org/r/117563/diff/


Testing
-------


Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140415/c65d48d3/attachment.html>


More information about the Plasma-devel mailing list