Review Request 117563: React to containment status changes

Marco Martin notmart at gmail.com
Mon Apr 14 14:54:10 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117563/#review55747
-----------------------------------------------------------


with the kwin autohide thing, setVisible() won't work, what you should do is to unset the atom to show and set it again to hide (even tough that may not actually hide it, need to check with Martin)

- Marco Martin


On April 14, 2014, 2:49 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117563/
> -----------------------------------------------------------
> 
> (Updated April 14, 2014, 2:49 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> At the moment the Panel didn't have any code to react status changes from the containment (and therefore its applets).
> 
> This patch aims to add this, only problem being that it doesn't work. The "unhide requested" and "unhiding" messages are being displayed though.
> 
> I've been looking for the code that does the actual display of the auto-hiding panels and I wasn't able to find it, help is welcome.
> 
> 
> Diffs
> -----
> 
>   shell/panelview.h 056a1e4 
>   shell/panelview.cpp 53d690a 
> 
> Diff: https://git.reviewboard.kde.org/r/117563/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140414/426c18b9/attachment.html>


More information about the Plasma-devel mailing list