Review Request 117455: [kglobalaccel] Remove Component::showKCM

[Martin Gräßlin]

> On April 9, 2014, 7:20 p.m., Martin Gräßlin wrote:
> > Oh I just found a usage in kglobaccel itself:
> > 
> >         KNotification *notification = new KNotification(
> >                 "newshortcutregistered",
> >                 KNotification::CloseOnTimeout,
> >                 q->parent());
> > 
> >         notification->setText(
> >                 i18n("The application %1 has registered a new global shortcut",
> >                         component->friendlyName()));
> > 
> >         notification->setActions( QStringList( i18n( "Open Global Shortcuts Editor" ) ) );
> > 
> >         notification->addContext( "application", component->friendlyName() );
> > 
> >         QObject::connect(notification, SIGNAL(action1Activated()),
> >                 component, SLOT(showKCM()));
> > 
> > 
> > Though I'm not sure what's the use case for this notification and the commit message which introduced it doesn't say anything.

This "problem" becomes obsolete with https://git.reviewboard.kde.org/r/117464/


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117455/#review55296
-----------------------------------------------------------


On April 9, 2014, 7:05 p.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117455/
> -----------------------------------------------------------
> 
> (Updated April 9, 2014, 7:05 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> [kglobalaccel] Remove Component::showKCM
> 
> Component::showKCM was a method exported to DBus to wrap the invocation
> of "kcmshell5 keys".
> 
> According to lxr there is no application using this DBus method and it's
> not much use anyway as it doesn't open the keys KCM for the component.
> 
> This removes the KIOWidgets dependency from kglobalaccel.
> 
> 
> Diffs
> -----
> 
>   kglobalaccel/CMakeLists.txt b77f85edab091fd260fb9bddb1ddb43df445c5fe 
>   kglobalaccel/component.h 019c315374ecd226cb0820519a76bdbc3ced678c 
>   kglobalaccel/component.cpp 72a4980a3c26140bde692d376338da03dc67086e 
> 
> Diff: https://git.reviewboard.kde.org/r/117455/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140410/7af60665/attachment.html>