<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117455/">https://git.reviewboard.kde.org/r/117455/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On April 9th, 2014, 7:20 p.m. CEST, <b>Martin Gräßlin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Oh I just found a usage in kglobaccel itself:
KNotification *notification = new KNotification(
"newshortcutregistered",
KNotification::CloseOnTimeout,
q->parent());
notification->setText(
i18n("The application %1 has registered a new global shortcut",
component->friendlyName()));
notification->setActions( QStringList( i18n( "Open Global Shortcuts Editor" ) ) );
notification->addContext( "application", component->friendlyName() );
QObject::connect(notification, SIGNAL(action1Activated()),
component, SLOT(showKCM()));
Though I'm not sure what's the use case for this notification and the commit message which introduced it doesn't say anything.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This "problem" becomes obsolete with https://git.reviewboard.kde.org/r/117464/</pre>
<br />
<p>- Martin</p>
<br />
<p>On April 9th, 2014, 7:05 p.m. CEST, Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated April 9, 2014, 7:05 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">[kglobalaccel] Remove Component::showKCM
Component::showKCM was a method exported to DBus to wrap the invocation
of "kcmshell5 keys".
According to lxr there is no application using this DBus method and it's
not much use anyway as it doesn't open the keys KCM for the component.
This removes the KIOWidgets dependency from kglobalaccel.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kglobalaccel/CMakeLists.txt <span style="color: grey">(b77f85edab091fd260fb9bddb1ddb43df445c5fe)</span></li>
<li>kglobalaccel/component.h <span style="color: grey">(019c315374ecd226cb0820519a76bdbc3ced678c)</span></li>
<li>kglobalaccel/component.cpp <span style="color: grey">(72a4980a3c26140bde692d376338da03dc67086e)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117455/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>