Review Request 117393: Move tests to root directories

[Martin Gräßlin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117393/#review55107
-----------------------------------------------------------


may I ask what's the motivation behind this change? The tests are so far grouped with the source code they belong to. E.g. moving the tests from the kwincompositing subdirectory to kwin core looks wrong to me. Also having the unit tests for the libs together with the libs seems right to me.

- Martin Gräßlin


On April 5, 2014, 11:05 p.m., Michael Palimaka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117393/
> -----------------------------------------------------------
> 
> (Updated April 5, 2014, 11:05 p.m.)
> 
> 
> Review request for kwin and Plasma.
> 
> 
> Repository: kwin
> 
> 
> Description
> -------
> 
> Move some tests and autotests from subdirectories to the root directory. Move the QtTest dependency to there where it is required. Add the option to disable building of tests.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 35fb9ac3b0f8506e6f0fd92b48ba60e83524f212 
>   autotests/CMakeLists.txt 475a7a5f9013ed16d37777bc05e9cba2ad033338 
>   kcmkwin/kwincompositing/CMakeLists.txt 8eb170bedd32f04f5d2cc0fbd3079758e6138cc6 
>   kcmkwin/kwincompositing/test/effectmodeltest.h  
>   kcmkwin/kwincompositing/test/effectmodeltest.cpp c2043a959c03b24ca81fe156b6a3b34427cfdae3 
>   kcmkwin/kwincompositing/test/modeltest.h  
>   kcmkwin/kwincompositing/test/modeltest.cpp  
>   libkwineffects/CMakeLists.txt 0544b0d441f3685240160f15e6c9890c8a92fec1 
>   libkwineffects/autotests/CMakeLists.txt 8973545cc21b010f1430cf7df20a29da5b14ab43 
>   libkwineffects/autotests/windowquadlisttest.cpp  
>   tabbox/CMakeLists.txt 76ba3a2499ca142bb82109db9d7239001ed7157e 
>   tabbox/autotests/CMakeLists.txt 4e83fa7524483d64ea149f0eb1818ea9f61cffe0 
>   tabbox/autotests/mock_declarative.cpp  
>   tabbox/autotests/mock_tabboxclient.h  
>   tabbox/autotests/mock_tabboxclient.cpp  
>   tabbox/autotests/mock_tabboxhandler.h  
>   tabbox/autotests/mock_tabboxhandler.cpp  
>   tabbox/autotests/test_desktopchain.cpp f7b7f39b791695e35bd81510f1e57137098026d8 
>   tabbox/autotests/test_tabbox_clientmodel.h  
>   tabbox/autotests/test_tabbox_clientmodel.cpp  
>   tabbox/autotests/test_tabbox_config.cpp 16d8986e3f9e9df2a11128a7ef4e48483568b394 
>   tabbox/autotests/test_tabbox_handler.cpp  
>   tests/CMakeLists.txt 39566e167156f3f513c10f94940c36814950b58c 
> 
> Diff: https://git.reviewboard.kde.org/r/117393/diff/
> 
> 
> Testing
> -------
> 
> Builds. Tests pass.
> 
> 
> Thanks,
> 
> Michael Palimaka
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140407/b2bb1506/attachment.html>