<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117393/">https://git.reviewboard.kde.org/r/117393/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">may I ask what's the motivation behind this change? The tests are so far grouped with the source code they belong to. E.g. moving the tests from the kwincompositing subdirectory to kwin core looks wrong to me. Also having the unit tests for the libs together with the libs seems right to me.</pre>
<br />
<p>- Martin Gräßlin</p>
<br />
<p>On April 5th, 2014, 11:05 p.m. CEST, Michael Palimaka wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kwin and Plasma.</div>
<div>By Michael Palimaka.</div>
<p style="color: grey;"><i>Updated April 5, 2014, 11:05 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kwin
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Move some tests and autotests from subdirectories to the root directory. Move the QtTest dependency to there where it is required. Add the option to disable building of tests.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Builds. Tests pass.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(35fb9ac3b0f8506e6f0fd92b48ba60e83524f212)</span></li>
<li>autotests/CMakeLists.txt <span style="color: grey">(475a7a5f9013ed16d37777bc05e9cba2ad033338)</span></li>
<li>kcmkwin/kwincompositing/CMakeLists.txt <span style="color: grey">(8eb170bedd32f04f5d2cc0fbd3079758e6138cc6)</span></li>
<li>kcmkwin/kwincompositing/test/effectmodeltest.h <span style="color: grey">()</span></li>
<li>kcmkwin/kwincompositing/test/effectmodeltest.cpp <span style="color: grey">(c2043a959c03b24ca81fe156b6a3b34427cfdae3)</span></li>
<li>kcmkwin/kwincompositing/test/modeltest.h <span style="color: grey">()</span></li>
<li>kcmkwin/kwincompositing/test/modeltest.cpp <span style="color: grey">()</span></li>
<li>libkwineffects/CMakeLists.txt <span style="color: grey">(0544b0d441f3685240160f15e6c9890c8a92fec1)</span></li>
<li>libkwineffects/autotests/CMakeLists.txt <span style="color: grey">(8973545cc21b010f1430cf7df20a29da5b14ab43)</span></li>
<li>libkwineffects/autotests/windowquadlisttest.cpp <span style="color: grey">()</span></li>
<li>tabbox/CMakeLists.txt <span style="color: grey">(76ba3a2499ca142bb82109db9d7239001ed7157e)</span></li>
<li>tabbox/autotests/CMakeLists.txt <span style="color: grey">(4e83fa7524483d64ea149f0eb1818ea9f61cffe0)</span></li>
<li>tabbox/autotests/mock_declarative.cpp <span style="color: grey">()</span></li>
<li>tabbox/autotests/mock_tabboxclient.h <span style="color: grey">()</span></li>
<li>tabbox/autotests/mock_tabboxclient.cpp <span style="color: grey">()</span></li>
<li>tabbox/autotests/mock_tabboxhandler.h <span style="color: grey">()</span></li>
<li>tabbox/autotests/mock_tabboxhandler.cpp <span style="color: grey">()</span></li>
<li>tabbox/autotests/test_desktopchain.cpp <span style="color: grey">(f7b7f39b791695e35bd81510f1e57137098026d8)</span></li>
<li>tabbox/autotests/test_tabbox_clientmodel.h <span style="color: grey">()</span></li>
<li>tabbox/autotests/test_tabbox_clientmodel.cpp <span style="color: grey">()</span></li>
<li>tabbox/autotests/test_tabbox_config.cpp <span style="color: grey">(16d8986e3f9e9df2a11128a7ef4e48483568b394)</span></li>
<li>tabbox/autotests/test_tabbox_handler.cpp <span style="color: grey">()</span></li>
<li>tests/CMakeLists.txt <span style="color: grey">(39566e167156f3f513c10f94940c36814950b58c)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117393/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>