Review Request 112812: Use type description sort order in devicenotifier when non-removable devices are displayed

[Jacopo De Simoi]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112812/#review40934
-----------------------------------------------------------


Let me have a look at the patch; I'll be able to do it tomorrow and commit it myself if it is ok. 

Thanks

__J 
Device notifier mantainer

- Jacopo De Simoi


On Sept. 19, 2013, 3:24 p.m., Benedikt Gollatz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112812/
> -----------------------------------------------------------
> 
> (Updated Sept. 19, 2013, 3:24 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> Use type description sort order in the devicenotifier applet when non-removable devices are configured to be displayed. This avoids apparently random sort order (by device engine population timestamp) and unneccessary ListView sections. The problem becomes apparent if other types of devices besides simple storage volumes are configured in /etc/fstab, like for example network mounts.
> 
> Fixes bug #324459.
> 
> 
> This addresses bug 324459.
>     http://bugs.kde.org/show_bug.cgi?id=324459
> 
> 
> Diffs
> -----
> 
>   plasma/generic/applets/devicenotifier/package/contents/ui/devicenotifier.qml 9b6132e 
> 
> Diff: http://git.reviewboard.kde.org/r/112812/diff/
> 
> 
> Testing
> -------
> 
> Works for me using KDE 4.10.5 packaged with Fedora 19.
> 
> 
> Thanks,
> 
> Benedikt Gollatz
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130928/410541d3/attachment.html>