Review Request 112812: Use type description sort order in devicenotifier when non-removable devices are displayed

[Benedikt Gollatz]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112812/
-----------------------------------------------------------

(Updated Sept. 19, 2013, 3:24 p.m.)


Review request for Plasma.


Changes
-------

Fix incorrect indenting in proposed patch


Description
-------

Use type description sort order in the devicenotifier applet when non-removable devices are configured to be displayed. This avoids apparently random sort order (by device engine population timestamp) and unneccessary ListView sections. The problem becomes apparent if other types of devices besides simple storage volumes are configured in /etc/fstab, like for example network mounts.

Fixes bug #324459.


This addresses bug 324459.
    http://bugs.kde.org/show_bug.cgi?id=324459


Diffs (updated)
-----

  plasma/generic/applets/devicenotifier/package/contents/ui/devicenotifier.qml 9b6132e 

Diff: http://git.reviewboard.kde.org/r/112812/diff/


Testing
-------

Works for me using KDE 4.10.5 packaged with Fedora 19.


Thanks,

Benedikt Gollatz

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130919/d514e96e/attachment.html>