Fwd: Reminder: use KF5::foo instead of ${foo_LIBRARIES} in CMakeLists
Sebastian Kügler
sebas at kde.org
Wed Sep 25 11:10:44 UTC 2013
On Wednesday, September 25, 2013 12:40:12 Stephen Kelly wrote:
> Sebastian Kügler wrote:
> > CMake-gods, can you confirm the below? (It's inconsistent with my
> > understanding, and how we've done it in the past months, I'd like to have
> > a specialist opinion before going around and changing every single
> > CMakeLists.txt in Plasma.)
>
> Running
>
> git log -S KI18n_LIBRARIES
>
> shows that I made a mistake and redefined the variable. Fixed now.
That wasn't my question, however. :)
So the verdict is to use variables?
What's the advantage here, all I hear is complaints that errors are harder to
find now.
Cheers,
--
sebas
http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9
More information about the Plasma-devel
mailing list