Review Request 112690: Take configure button width into account for summary label

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112690/#review39896
-----------------------------------------------------------

Ship it!


Ship It!

- Marco Martin


On Sept. 12, 2013, 2:50 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112690/
> -----------------------------------------------------------
> 
> (Updated Sept. 12, 2013, 2:50 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> Started to bug me that titles of KTP messages always ran underneath the configure button. This fixes this.
> 
> - Renamed configureButton to settingsButton in Notification delegate to be consistent with LastNotificationPopup
> - Had to remove RichText from LastNotificationPopup summary label for the eliding to work properly, but the Notification delegate doesn't have it either
> 
> 
> Diffs
> -----
> 
>   plasma/generic/applets/notifications/contents/ui/LastNotificationPopup.qml 9d3d8aa 
>   plasma/generic/applets/notifications/contents/ui/NotificationDelegate/NotificationDelegate.qml ff5be93 
> 
> Diff: http://git.reviewboard.kde.org/r/112690/diff/
> 
> 
> Testing
> -------
> 
> Tested both popup and history with both configurable and non-configurable (kdialog) notifications
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130912/aea9dc17/attachment.html>