Review Request 112690: Take configure button width into account for summary label

Kai Uwe Broulik kde at privat.broulik.de
Thu Sep 12 14:50:06 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112690/
-----------------------------------------------------------

Review request for Plasma.


Description
-------

Started to bug me that titles of KTP messages always ran underneath the configure button. This fixes this.

- Renamed configureButton to settingsButton in Notification delegate to be consistent with LastNotificationPopup
- Had to remove RichText from LastNotificationPopup summary label for the eliding to work properly, but the Notification delegate doesn't have it either


Diffs
-----

  plasma/generic/applets/notifications/contents/ui/LastNotificationPopup.qml 9d3d8aa 
  plasma/generic/applets/notifications/contents/ui/NotificationDelegate/NotificationDelegate.qml ff5be93 

Diff: http://git.reviewboard.kde.org/r/112690/diff/


Testing
-------

Tested both popup and history with both configurable and non-configurable (kdialog) notifications


Thanks,

Kai Uwe Broulik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130912/4f3d3368/attachment-0001.html>


More information about the Plasma-devel mailing list