Review Request 112674: Bugfix: Make the calculator applet calculate correct

[Paul Rohrbach]

> On Sept. 11, 2013, 5:28 p.m., Sebastian Kügler wrote:
> > applets/calculator/package/contents/ui/calculator.qml, line 41
> > <http://git.reviewboard.kde.org/r/112674/diff/1/?file=188980#file188980line41>
> >
> >     Why is this change needed (operator initialized to undefined)?

This should not be part of the patch, i didn't saw it when uploading the patch... I changed the line, because it created a warning for me (Unable to assign [undefined] to QString operator) and I wanted to test what the problem was. I changed it back in the second diff.


> On Sept. 11, 2013, 5:28 p.m., Sebastian Kügler wrote:
> > applets/calculator/package/contents/ui/calculator.qml, line 111
> > <http://git.reviewboard.kde.org/r/112674/diff/1/?file=188980#file188980line111>
> >
> >     space after if and before (

Oops, sorry for that. It is also corrected in the second diff.


- Paul


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112674/#review39846
-----------------------------------------------------------


On Sept. 11, 2013, 5 p.m., Paul Rohrbach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112674/
> -----------------------------------------------------------
> 
> (Updated Sept. 11, 2013, 5 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> This patch should solve bug 313869.
> 
> The bug reported this behaviour: if you press something like 'a+b+c=', the result would be incorrect because the calculator plasmoid wrongly resets the calculator when pressing 'c'. The intended behaviour is that the calculation is cleared when pressing a number after pressing '='.
> 
> This patch adds a variable to determine this situation correctly.
> 
> 
> This addresses bug 313869.
>     http://bugs.kde.org/show_bug.cgi?id=313869
> 
> 
> Diffs
> -----
> 
>   applets/calculator/package/contents/ui/calculator.qml b4f0654 
> 
> Diff: http://git.reviewboard.kde.org/r/112674/diff/
> 
> 
> Testing
> -------
> 
> It works for me in Plasmate.
> 
> 
> Thanks,
> 
> Paul Rohrbach
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130911/2a97b155/attachment-0001.html>