Review Request 112674: Bugfix: Make the calculator applet calculate correct

[Sebastian Kügler]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112674/#review39846
-----------------------------------------------------------


Almost good, two nitpicks inside.


applets/calculator/package/contents/ui/calculator.qml
<http://git.reviewboard.kde.org/r/112674/#comment29383>

    Why is this change needed (operator initialized to undefined)?



applets/calculator/package/contents/ui/calculator.qml
<http://git.reviewboard.kde.org/r/112674/#comment29381>

    space after if and before (


- Sebastian Kügler


On Sept. 11, 2013, 5 p.m., Paul Rohrbach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112674/
> -----------------------------------------------------------
> 
> (Updated Sept. 11, 2013, 5 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> This patch should solve bug 313869.
> 
> The bug reported this behaviour: if you press something like 'a+b+c=', the result would be incorrect because the calculator plasmoid wrongly resets the calculator when pressing 'c'. The intended behaviour is that the calculation is cleared when pressing a number after pressing '='.
> 
> This patch adds a variable to determine this situation correctly.
> 
> 
> This addresses bug 313869.
>     http://bugs.kde.org/show_bug.cgi?id=313869
> 
> 
> Diffs
> -----
> 
>   applets/calculator/package/contents/ui/calculator.qml b4f0654 
> 
> Diff: http://git.reviewboard.kde.org/r/112674/diff/
> 
> 
> Testing
> -------
> 
> It works for me in Plasmate.
> 
> 
> Thanks,
> 
> Paul Rohrbach
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130911/f15a153a/attachment.html>