Review Request 112502: Roughly port devicenotifier to plasma2

[Bhushan Shah]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112502/
-----------------------------------------------------------

(Updated Sept. 4, 2013, 10:33 a.m.)


Review request for Plasma and Sebastian Kügler.


Changes
-------

QIcon("blah") -> "blah"


Description
-------

Changed imports
Install package in CMakeLists.txt
Removed Plasma.Theme
Adjusted namespace where necessary
other changes


Diffs (updated)
-----

  plasma/generic/applets/CMakeLists.txt a84c1dc 
  plasma/generic/applets/devicenotifier/CMakeLists.txt 8d70303 
  plasma/generic/applets/devicenotifier/package/contents/ui/ActionItem.qml 1394d57 
  plasma/generic/applets/devicenotifier/package/contents/ui/DeviceItem.qml f6e57e9 
  plasma/generic/applets/devicenotifier/package/contents/ui/StatusBar.qml 11e67d4 
  plasma/generic/applets/devicenotifier/package/contents/ui/devicenotifier.qml 9b6132e 
  plasma/generic/applets/devicenotifier/package/metadata.desktop 6d24cc4 

Diff: http://git.reviewboard.kde.org/r/112502/diff/


Testing
-------

compiles - nothing needs to compile.
installs - check
works - somewhat, shows attached device, installed test action.

However there are many glitches..


Thanks,

Bhushan Shah

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130904/4fb622bc/attachment.html>