Review Request 112502: Roughly port devicenotifier to plasma2

[Bhushan Shah]

> On Sept. 4, 2013, 8:50 a.m., Kai Uwe Broulik wrote:
> > plasma/generic/applets/devicenotifier/package/contents/ui/DeviceItem.qml, line 90
> > <http://git.reviewboard.kde.org/r/112502/diff/1/?file=186957#file186957line90>
> >
> >     QIcon(deviceItem.icon) ? deviceItem.icon
> >     (I think)
> 
> Kai Uwe Broulik wrote:
>     Whoops, ReviewBoard screwed up the encoding of the arrow, hence the question mark.
>     Remove the QIcon, that should work.

You meant this arrow?? > ??


- Bhushan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112502/#review39319
-----------------------------------------------------------


On Sept. 4, 2013, 7:11 a.m., Bhushan Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112502/
> -----------------------------------------------------------
> 
> (Updated Sept. 4, 2013, 7:11 a.m.)
> 
> 
> Review request for Plasma and Sebastian Kügler.
> 
> 
> Description
> -------
> 
> Changed imports
> Install package in CMakeLists.txt
> Removed Plasma.Theme
> Adjusted namespace where necessary
> other changes
> 
> 
> Diffs
> -----
> 
>   plasma/generic/applets/CMakeLists.txt a84c1dc 
>   plasma/generic/applets/devicenotifier/CMakeLists.txt 8d70303 
>   plasma/generic/applets/devicenotifier/package/contents/ui/ActionItem.qml 1394d57 
>   plasma/generic/applets/devicenotifier/package/contents/ui/DeviceItem.qml f6e57e9 
>   plasma/generic/applets/devicenotifier/package/contents/ui/StatusBar.qml 11e67d4 
>   plasma/generic/applets/devicenotifier/package/contents/ui/devicenotifier.qml 9b6132e 
>   plasma/generic/applets/devicenotifier/package/metadata.desktop 6d24cc4 
> 
> Diff: http://git.reviewboard.kde.org/r/112502/diff/
> 
> 
> Testing
> -------
> 
> compiles - nothing needs to compile.
> installs - check
> works - somewhat, shows attached device, installed test action.
> 
> However there are many glitches..
> 
> 
> Thanks,
> 
> Bhushan Shah
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130904/7cd52623/attachment.html>