Review Request 109340: Use default background colours for the konsolepreviewer

Tianyu Zhu tian.tian098 at gmail.com
Tue Oct 29 10:51:20 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109340/
-----------------------------------------------------------

(Updated Oct. 29, 2013, 10:51 a.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma.


Bugs: https://bugs.kde.org/show_bug.cgi?id=316274
    http://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=316274


Repository: plasmate


Description
-------

- Deleted lines hard-coding the background of the konsolepreviwer to white.


Diffs
-----

  plasmate/konsole/konsolepreviewer.h 543ff77 
  plasmate/konsole/konsolepreviewer.cpp 05d426e 

Diff: http://git.reviewboard.kde.org/r/109340/diff/


Testing
-------

Tested on Kubuntu 12.10 with KDE 4.10.1
Tested with both the default and Krita-Dark colour scheme. In both cases, the text in the konsolepreviewer shows up well against its background.


Thanks,

Tianyu Zhu

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20131029/6db85d78/attachment.html>


More information about the Plasma-devel mailing list