Review Request 107908: Fix dismissing LastNotificationPopup often failing
Kai Uwe Broulik
kde at privat.broulik.de
Sun Oct 13 18:16:57 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107908/
-----------------------------------------------------------
(Updated Oct. 13, 2013, 6:16 p.m.)
Status
------
This change has been discarded.
Review request for Plasma and Marco Martin.
Bugs: 311413
http://bugs.kde.org/show_bug.cgi?id=311413
Repository: kde-workspace
Description
-------
This patch disables the setCustomNotification while a button (close, next, back) is pressed, to prevent popup re-shifting which seems to eat the clicked event.
Problem is more deep in Plasma but has been around since Plasma exists, so this should fix it for the notifications.
Diffs
-----
plasma/generic/applets/notifications/contents/ui/LastNotificationPopup.qml e63526b
Diff: http://git.reviewboard.kde.org/r/107908/diff/
Testing
-------
kdialog --passivepopup "bla"
click, closes.
Thanks,
Kai Uwe Broulik
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20131013/06a51b62/attachment.html>
More information about the Plasma-devel
mailing list