Review Request 110288: Checks if an optional field was instantiated before accessing it

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110288/#review41596
-----------------------------------------------------------


This review has been submitted with commit 61d18f327ccec54622166464d069b43a4b99a5e7 by Albert Astals Cid on behalf of Denis Falqueto to branch master.

- Commit Hook


On May 3, 2013, 8:38 p.m., Denis Falqueto wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110288/
> -----------------------------------------------------------
> 
> (Updated May 3, 2013, 8:38 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 319291
>     http://bugs.kde.org/show_bug.cgi?id=319291
> 
> 
> Repository: plasmate
> 
> 
> Description
> -------
> 
> The private field m_konsolewidget is initialized only on some specific cases, so it should be accessed with caution. But there are some places in witch it's being used without checking if it was instantiated or not. This patch fixes those accesses, by checking if it is instantiated or not.
> 
> 
> Diffs
> -----
> 
>   plasmate/mainwindow.cpp 1ef5a81 
> 
> Diff: http://git.reviewboard.kde.org/r/110288/diff/
> 
> 
> Testing
> -------
> 
> I've created a data engine in python successfully.
> 
> 
> Thanks,
> 
> Denis Falqueto
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20131012/ae622e63/attachment.html>