Review Request 110288: Checks if an optional field was instantiated before accessing it

[Bhushan Shah]

> On May 4, 2013, 2:44 p.m., Giorgos Tsiapaliokas wrote:
> > The patch is ok, it can go in.
> > 
> > Are you familiar with out git workflow policy?
> > 
> > http://community.kde.org/Plasma/IntegrationBranches/GeneralPolicy
> > 
> > If you have any questions don't hesitate to ask :)
> 
> Albert Astals Cid wrote:
>     Janitorial dude question: Has this been commited and you forgot to mark it as submitted or it does still need submitting?
>
> 
> Giorgos Tsiapaliokas wrote:
>     No this hasn't been submitted yet. I am waiting for the contributor.
>     I am aware of the existence of this review. If the contributor doesn't
>     show up I will submit it.
> 
> Albert Astals Cid wrote:
>     FYI The contributor can't commit since he doesn't have a commiter account. You can wait all you want, it won't happen.

ping?


- Bhushan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110288/#review31994
-----------------------------------------------------------


On May 4, 2013, 2:08 a.m., Denis Falqueto wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110288/
> -----------------------------------------------------------
> 
> (Updated May 4, 2013, 2:08 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 319291
>     http://bugs.kde.org/show_bug.cgi?id=319291
> 
> 
> Repository: plasmate
> 
> 
> Description
> -------
> 
> The private field m_konsolewidget is initialized only on some specific cases, so it should be accessed with caution. But there are some places in witch it's being used without checking if it was instantiated or not. This patch fixes those accesses, by checking if it is instantiated or not.
> 
> 
> Diffs
> -----
> 
>   plasmate/mainwindow.cpp 1ef5a81 
> 
> Diff: http://git.reviewboard.kde.org/r/110288/diff/
> 
> 
> Testing
> -------
> 
> I've created a data engine in python successfully.
> 
> 
> Thanks,
> 
> Denis Falqueto
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20131012/4328fa05/attachment.html>